Increase accscalingshift and include countok in hit proportion
#31195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BabySnakes101
approved these changes
Dec 19, 2024
tsunyoku
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, accuracy scaling (mainly affecting the lower end) was set to 300, decreasing values for mid-range players. In response for accuracy not being weighted as highly in the lower OD's, this has been increased to better align with previous values.
Similarly, feedback from the community indicated that the variance in % of accuracy corresponding to accuracy PP values across different OD's was minimal, this has been tweaked to included a
countokfactor to the proportion of greats + goods hit.Old:
double p = totalSuccessfulHits / n;New:
double p = Math.Max(0, totalSuccessfulHits - 0.0005 * countOk) / n;Also shuffles around the order of variables, for easier readability of what is actually being returned. This includes moving the null check into the return line.